Skip to content

Check that this module defaults to "not selected" in KConfig #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
szczys opened this issue Sep 12, 2022 · 1 comment · Fixed by #48
Closed

Check that this module defaults to "not selected" in KConfig #46

szczys opened this issue Sep 12, 2022 · 1 comment · Fixed by #48
Assignees
@DhruvaG2000

Comments

@szczys
Copy link
Collaborator

szczys commented Sep 12, 2022 •
edited
Loading

When building a project that does not use the Arduino API Module, it is still selected and built:

ZEPHYR_ARDUINO_API_MODULE(=y)                                                                                                                                                 
menu "arduino-api (/home/mike/compile/golioth-zephyr-workspace/modules/lib/Arduino-Zephyr-API)"

We should check that the KConfig for this symbol defaults to n

To reproduce

  1. Go to the zephyr drectory
  2. west build -b arduino_nano_33_ble samples/basic/minimal/ -p
  3. Build will fail with devicetree errors
  4. west build -t menuconfig
  5. /arduino will pull up a search that shows the Arduino API Module is enabled but it should not be.
@DhruvaG2000
Copy link
Collaborator

DhruvaG2000 commented Sep 14, 2022 •
edited
Loading

@szczys latest PR: #48 fixes that in menuconfig:

arduino

ARDUINO_API(=n) "ARDUINO_API"
BOARD_ARDUINO_NANO_33_BLE(=y) "Arduino Nano 33 BLE board"
BOARD_ARDUINO_NANO_33_BLE_SENSE(=n) "Arduino Nano 33 BLE Sense board"

this is inside the menuconfig UI.

Also, no more pesky DT errors ;)

DhruvaG2000 added a commit that referenced this issue Sep 14, 2022
@DhruvaG2000
CMakelists: conditionally add subdir if ARDUINO en
67b622d 
* Conditionally include sub directories specific to the
ARDUINO_API module in CMAkelists
* Solve #46

Signed-off-by: Dhruva Gole <[email protected]>
@DhruvaG2000 DhruvaG2000 self-assigned this Sep 14, 2022
@DhruvaG2000 DhruvaG2000 mentioned this issue Sep 14, 2022
Merged
DhruvaG2000 added a commit that referenced this issue Sep 16, 2022
@DhruvaG2000
CMakelists: conditionally add subdir if ARDUINO en
a88eda6 
* Conditionally include sub directories specific to the
ARDUINO_API module in CMAkelists
* Solve #46

Signed-off-by: Dhruva Gole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DhruvaG2000 DhruvaG2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kconfig: Update to use imply and rid module.conf zephyrproject-rtos/gsoc-2022-arduino-core
2 participants
@szczys @DhruvaG2000