Skip to content

chore(package): update webpack-log v1.0.1...1.2.0 (dependencies) #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

svicalifornia
Copy link
Contributor

Fixes #317.

@jsf-clabot
Copy link

jsf-clabot commented Aug 14, 2018

CLA assistant check
All committers have signed the CLA.

@svicalifornia
Copy link
Contributor Author

So updating a dependency to the version mutually recommended in #310 breaks your test suite. Well, that's fun. I'll have to come back to fix this later, unless someone else can help sooner.

@alexander-akait
Copy link
Member

@svicalifornia please fix tests

@svicalifornia
Copy link
Contributor Author

svicalifornia commented Aug 14, 2018

@evilebottnawi I already said above that I would. It's gonna take me a few days to get back to this, though.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures are weird tbh, it's likely something changed in webpack itself making the bundle a bit larger. Also why is it required to be exactly 3645 in size ? I would suggest to either update the expected value(s) to the currently recieved ones or to remove this brittle assertion altogether. Anyways it seems this is unrelated to changes made by the PR itself

@alexander-akait
Copy link
Member

@michael-ciniawsky can we fix it in this PR?

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Aug 20, 2018

I think so, but I'm not 💯 sure if the content-length check has an important meaning or not, from the test suit it looks like it doesn't (app.js is e.g not an injected script by the middleware or the like, just a test app.js bundle (which can change in size easily)). I would suggest to update the size to the currently recieved value for now and add a comment that this needs triage and refactor from our side :)

@alexander-akait
Copy link
Member

@michael-ciniawsky let's do it, feel free create separate PR for this

@alexander-akait
Copy link
Member

/cc @michael-ciniawsky need patch release, can you have access for this?

@michael-ciniawsky
Copy link
Member

No 😞 and I just saw you also don't have 🤢...

@alexander-akait
Copy link
Member

@michael-ciniawsky waiting for access

@michael-ciniawsky michael-ciniawsky changed the title Update webpack-log dependency to 1.2.0 chore(package): update webpack-log v1.0.1...1.2.0 (dependencies) Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants