-
-
Notifications
You must be signed in to change notification settings - Fork 380
chore(package): update webpack-log
v1.0.1...1.2.0 (dependencies
)
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So updating a dependency to the version mutually recommended in #310 breaks your test suite. Well, that's fun. I'll have to come back to fix this later, unless someone else can help sooner. |
@svicalifornia please fix tests |
@evilebottnawi I already said above that I would. It's gonna take me a few days to get back to this, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures are weird tbh, it's likely something changed in webpack
itself making the bundle a bit larger. Also why is it required to be exactly 3645
in size ? I would suggest to either update the expected value(s) to the currently recieved ones or to remove this brittle assertion altogether. Anyways it seems this is unrelated to changes made by the PR itself
@michael-ciniawsky can we fix it in this PR? |
I think so, but I'm not 💯 sure if the |
@michael-ciniawsky let's do it, feel free create separate PR for this |
/cc @michael-ciniawsky need patch release, can you have access for this? |
No 😞 and I just saw you also don't have 🤢... |
@michael-ciniawsky waiting for access |
webpack-log
v1.0.1...1.2.0 (dependencies
)
Fixes #317.