-
-
Notifications
You must be signed in to change notification settings - Fork 380
Version number of webpack-log dependency is incorrect #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@svicalifornia why just doesn't update own packages? |
Telling people to blow away their node_modules and re-install is not only stupid but can also be dangerous. Due to inconsistencies in how npm modules use version numbers, you can never be sure that the updates you'll get will be safe, and sometimes you can't afford the full regression test required to validate the new updates. The whole point of listing the dependencies in package.json is so that the package manager can decide what needs to be installed or upgraded. We shouldn't have to second-guess the package manager and force-update because your library didn't specify its dependencies correctly. If this package only works with webpack-log 1.2.0 and above, then you should specify that in package.json, and then npm/yarn would know when it needs to update that package if an older version is already installed. The current version range |
My exasperation above resulted from reading through the first attempt to get this fixed in #310, seeing it dismissed for no good reason, and then seeing the same thing happen again when I re-raised the issue herein. I'm not understanding why there have been so many defenses or shrugs from the maintainers regarding a bad dependency spec, especially after it is reported by multiple users of this library. |
There is no harm in bumping the dependency to start from |
Thank you. |
Issue #310 rightly pointed out that the version 1.0.1 of webpack-log does not work with webpack-dev-middleware, so "^1.0.1" is an invalid semvar dependency specification for this package. "^1.0.1" indicates that version 1.0.1 should work, which is false. The resolution of "^1.0.1" to a later version of webpack-log on a fresh install is not a valid argument, for multiple reasons:
As the reporter of #310 (somewhat snarkily) pointed out, this trouble could be avoided by you folks being good stewards of your package.json and updating the version number of webpack-log to match only the versions that are compatible with webpack-dev-middleware.
I will make it easy for you by contributing the PR momentarily.
The text was updated successfully, but these errors were encountered: