Fix types #901
Fix types #901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 91.23% 90.29% -0.94%
==========================================
Files 5 5
Lines 821 824 +3
Branches 219 220 +1
==========================================
- Hits 749 744 -5
- Misses 66 70 +4
- Partials 6 10 +4
Continue to review full report at Codecov.
|
|
@barak007 I will merge it and do release, feel free to improve any types (if you found a typo/wrong types/somethings else) |
| @@ -187,3 +205,34 @@ type RuntimeOptions = { | |||
| attributes: Record<string, string> | undefined; | |||
| }; | |||
| type TODO = any; | |||
| type CssModule = import("webpack").Module & { | |||
| content: Buffer; | |||
There was a problem hiding this comment.
@alexander-akait can this content accept string or Buffer is the only possible value?
There was a problem hiding this comment.
We have content: Buffer.from(content) in our code, so I used Buffer, but webpack can accept strings too, need to tests, if it will work feel free to improve it
This PR contains a:
Motivation / Use-Case
fixes #900
Breaking Changes
No
Additional Info
Also fix bug with relative paths for hot code, it was broken before...