fix: [2.5.1] mark getCssModule and getCssDependency as public

[barak007]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

Mark getCssModule and getCssDependency as public
getCssModule is the base of our integration to mini-css-extract-plugin added support done here #703
We ended up not using getCssDependency but I feel like it should also be public.
These are the basic building blocks for proper integration to css bundling in webpack

Breaking Changes

Fix types

Additional Info

[linux-foundation-easycla]

• ❌ - barak igal The commit (b8d2551 ,7c6ffbc259def1bf04b9678c177ce1a20ebe07c8) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[alexander-akait]

There is ts bug here as you can see...

[alexander-akait]

I tried to solve it, but no luck, ideally we should move CssModules and CssDependecy on top, but we can't do it due design...

[barak007]

I see. I also missed the actual private in the d.ts. checking...I didn't realized it's generated.

[alexander-akait]

If you found how we can solve it or ideas, I will fix and merge it

[barak007]

I have a fix but I got issues with the pre-commit hook lint-staged

[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for *
[STARTED] Running tasks for *.{js,ts}
[STARTED] prettier --write --ignore-unknown
[STARTED] eslint --cache --fix
[FAILED] �[91meslint --cache --fix�[39m �[2m[FAILED]�[22m
[SUCCESS] prettier --write --ignore-unknown
[SUCCESS] Running tasks for *
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SKIPPED] Skipped because of errors from tasks.
[STARTED] Reverting to original state because of errors...
[SUCCESS] Reverting to original state because of errors...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...

�[91m�[91m✖�[91m eslint --cache --fix:�[39m

C:\projects\mini-css-extract-plugin\public.d.ts
  1:4  error  Parsing error: Missing semicolon. (1:4)

C:\projects\mini-css-extract-plugin\types\index.d.ts
  1:7  error  Parsing error: Unexpected token, expected "{" (1:7)

Not sure what's the problem there I can't identify any problem with the code.

I can force push if you want to check it.

[alexander-akait]

skip hooks, I will fix it

[alexander-akait]

Just send code

[codecov]

Codecov Report

Merging #900 (7c6ffbc) into master (e4f4c1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files           5        5           
  Lines         821      821           
  Branches      219      219           
=======================================
  Hits          749      749           
  Misses         66       66           
  Partials        6        6           

Impacted Files	Coverage Δ
src/index.js	96.25% <ø> (ø)
src/loader.js	88.95% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f4c1e...7c6ffbc. Read the comment docs.

[barak007]

I'm sorry I did only the basic type I think the static methods still needs to typed in the public.d.ts.

[alexander-akait]

@barak007 Found better way #901, anyway we have some problems on webpack side (using your implementation also have these problems):
1 Source is private and should be exported by webpack (now use any), feel free to send a PR
2. Problems with null/undefined (we should enable strict mode), it is not big problems, just can be misleading in some situations (recently we already fix these problems for callback)