feat(index): add [contenthash] support
#30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 157 167 +10
Branches 32 34 +2
====================================
- Misses 125 133 +8
- Partials 32 34 +2
Continue to review full report at Codecov.
|
|
Documentation should be updated as well! |
|
Let's get this merged @sokra :) |
|
@michael-ciniawsky any time table when this gets merged finally? |
|
@vertic4l I don't have access here, that's up to Tobias atm :), From my side it's g2g, the only thing notable here is that the hash of the JS chunk will nevertheless change when the CSS changes... |
|
So it mitigates caching problems at best (the CSS will keep the hash) |
|
@michael-ciniawsky well, i can't actually close my own PR within a project (which updates to webpack 4 setup) as long as this plugin or ExtractTextPlugin doesn't work properly with incremental builds, contentHash and webpack 4. Pretty annoying actually, but can't really help either :/ |
| // add contenthash support | ||
| compiler.hooks.emit.tap(pluginName, (compilation) => { | ||
| const regexp = /\[(?:(\w+):)?contenthash(?::([a-z]+\d*))?(?::(\d+))?\]/ig; | ||
| Object.keys(compilation.assets).forEach((filename) => { |
There was a problem hiding this comment.
Not available in node 6.
michael-ciniawsky
changed the title
[contenthash] support
|
I'll add Thanks for your PR anyway. |
|
So would we then want to use |
IssuesFirst time doing webpack plugin code :) Hope it won't break anything.