-
-
Notifications
You must be signed in to change notification settings - Fork 384
Content hash support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Needs to be added! There were some issues with Cache Busting not working. |
FYI. From slack:
It is not necessary to implement this here ⭐ Just wait next release |
/cc @michael-ciniawsky what do you think, better wait webpack release? |
Shouldn't the chunk hash include the contents of the CSS sources, just as it does for the JS sources? |
That's what the chunk hash does, yes. This is the content hash for the individual asset. |
Yes; but the CSSModule defined by this plugin doesn't update the chunk hash—it just relies on the updateHash implementation in Module. Perhaps that should be treated as a separate issue? |
The impl has finished. CSS module test has also been added. Just waiting for webpack 4.3.0 release with contenthash support to send a PR. https://github.com/webpack-contrib/mini-css-extract-plugin/tree/feature/contenthash |
@sokra thanks, this is awesome! Webpack 4.3.0 has just been released. |
This should work now. |
Sorry, my mistake. #59 has to land first. |
Using
[email protected]
Is it possible to support a content hash in the filename, like extract-text-webpack-plugin's
[contenthash]
?Using
filename: '[name].[chunkhash:8].css'
the.css
hash is also changing when only the JavaScript in the chunk has changed:The text was updated successfully, but these errors were encountered: