Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

refactor(plugin): v4.0.0 #768

Closed
wants to merge 15 commits into from
Closed

refactor(plugin): v4.0.0 #768

wants to merge 15 commits into from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Apr 2, 2018 •
edited
Loading

joshwiens and others added 14 commits April 2, 2018 02:20
@joshwiens
chore(package): update engines && peerDependencies
9f230f5 
BREAKING CHANGE: requires `node >= v6.0.0` (`engines`)
@joshwiens
refactor(helpers): update deprecated chunk.parents
6f6181c
@joshwiens
refactor: update deprecated chunk.chunks
f81bff1
@joshwiens
chore(package): update webpack-defaults v1.6.0...2.0.0-rc.3
29fd09d
@joshwiens
chore(package): update webpack v3.10.0...4.0.0-alpha.2
09c94d4
@horo42 @joshwiens
refactor(ExtractTextPlugin): update to new plugin system and API's (#707
9ad2421 
)

BREAKING CHANGE: requires `webpack >= v4.0.0`
@michael-ciniawsky @joshwiens
chore(package): rm yarn.lock
ccf1690
@michael-ciniawsky @joshwiens
style(.eslintrc): webpack-defaults v2.0.0-rc.4
e42ef22
@michael-ciniawsky @joshwiens
chore(release): 4.0.0-alpha.0
24ed0cf
@joshwiens
fix(index): don't crash with dynamic import() (#728)
602a5b0
@michael-ciniawsky @joshwiens
chore(release): 4.0.0-beta.0
2c16da7
@lili21 @joshwiens
fix(index): remove empty assets (#746)
6078876
@joshwiens
chore(pacakge): Update to latest defaults
8345d35
@joshwiens
test(integration): Update config & snapshot for hashed-module-ids
34e5083
alexander-akait
alexander-akait approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. i think we should add information about MCEP vs ETWP

@joshwiens
Copy link
Member Author

joshwiens commented Apr 2, 2018 •
edited
Loading

@evilebottnawi - I've rebased in latest master, and yes I agree we should add information about MCEP so users that can get away with limited functionality can migrate over though the lack of HMR support will be a hangup for some.

Currently on next the splitted-mix-multiple-entries test is failing & is a legitimate failure due to shouldExtract being set to true where it shouldn't leading to side effects.

You are welcome to target #710 to next & we can land it here. I'm planning on finishing this in the next day or two & getting it into master.

@ticky ticky mentioned this pull request Sep 14, 2018
Merged
@michael-ciniawsky
Copy link
Member

Superseded by mini-css-extract-plugin

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Oct 18, 2018 •
edited
Loading

⚠️ Do NOT delete this branch

@michael-ciniawsky michael-ciniawsky changed the title refactor: ExtractText 4.0 merge refactor(plugin): v4.0.0 Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
semver: Major status: Declined type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshwiens @michael-ciniawsky @alexander-akait @horo42 @lili21 @aliai