fix(index): remove empty assets #746
Conversation
|
|
|
Hello, anyone please look at this ? |
|
@lili21 can you add tests? |
alexander-akait
requested review from
alexander-akait,
michael-ciniawsky and
joshwiens
commitlint.config.js
Outdated
| @@ -12,7 +12,7 @@ const Configuration = { | |||
| 'subject-full-stop': [2, 'never', '.'], | |||
| 'type-case': [2, 'always', 'lower-case'], | |||
| 'type-empty': [2, 'never'], | |||
| 'type-enum': [ | |||
| 'type-enum': [2, 'always', [ | |||
There was a problem hiding this comment.
Also don't change eslint config file
There was a problem hiding this comment.
I think this lint config is invalid. cause commitlint keep yelling at me about value of type-enum is wrong.
There was a problem hiding this comment.
@lili21 this PR please send to webpack-default repo
There was a problem hiding this comment.
looks like webpack-default have nothing to do with commitlint.config.js
There was a problem hiding this comment.
|
I guess I have to change the intergration test code to test empty chunk rather than just add test case. |
|
what I mean is I can't just add test case. I have to change the |
|
couldn't find a way to test it without change the way of integration test. maybe you can give me some advice ? |
| @@ -0,0 +1,2 @@ | |||
| require('./a.txt'); | |||
| require('./b.txt'); | |||
There was a problem hiding this comment.
Add \n in end of file 👍
| expect(readFileOrEmpty(actualPath)).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| glob |
There was a problem hiding this comment.
I need to get all files in a directory recursively. I can do it without glob, but why not ?
michael-ciniawsky
changed the title
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 3 (required)
severity: 3 (broken)
labels
|
I see the "just use |
|
Yep, I will cut a 'final' release including this fix. I just need to finish some other chores before and add a deprecation note to the README and |
Issues