Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(index): remove empty assets #746

Merged
merged 3 commits into from
Mar 19, 2018
Merged

fix(index): remove empty assets #746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3a8148
fix: remove empty assets
lili21 Mar 9, 2018
2f71114
test: add test for empty chunk.
lili21 Mar 15, 2018
b128739
style: new line at the end of files
lili21 Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const Configuration = {
'subject-full-stop': [2, 'never', '.'],
'type-case': [2, 'always', 'lower-case'],
'type-empty': [2, 'never'],
'type-enum': [
'type-enum': [2, 'always', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't change eslint config file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this lint config is invalid. cause commitlint keep yelling at me about value of type-enum is wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lili21 this PR please send to webpack-default repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like webpack-default have nothing to do with commitlint.config.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lili21 https://github.com/webpack-contrib/webpack-defaults/tree/next/templates

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

'build',
'chore',
'ci',
Expand All @@ -24,7 +24,7 @@ const Configuration = {
'revert',
'style',
'test',
],
]],
},
};

Expand Down
4 changes: 4 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ class ExtractTextPlugin {
extractedChunk
);

if (!source.size()) {
return;
}

const getPath = (format) =>
compilation
.getPath(format, {
Expand Down