Skip to content

chore(package): upgrade to postcss v6.0.0 && cssnano v4.0.0-rc.2 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ylemkimon
Copy link

@ylemkimon ylemkimon commented Jan 4, 2018

What kind of change does this PR introduce?
Dependency upgrade

Did you add tests for your changes?
N/A
If relevant, did you update the README?
N/A

Summary
Upgraded to PostCSS 6/cssnano 4: Fixes #535

Does this PR introduce a breaking change?
As cssnano has multiple breaking changes, old configurations may not work.

Other information
Blocked by: cssnano 4 release(cssnano/cssnano#408)

Meanwhile you can use github:ylemkimon/css-loader as dependency.

Updated cssnano options and its test(the order of declarations has been
changed).
Upgraded to icss-utils 3, Codecov 3, ESLint 4, Mocha 4, should 13
@jsf-clabot
Copy link

jsf-clabot commented Jan 4, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky
Copy link
Member

We already working in css-loader v1.0.0, I know this is overdue, but in the current semver range this update likely won't happen

@michael-ciniawsky michael-ciniawsky changed the title Upgrade to PostCSS 6/cssnano 4 chore(package): upgrade to postcss v6.0.0 && cssnano v4.0.0-rc.2 Jan 4, 2018
@ylemkimon
Copy link
Author

@michael-ciniawsky I've always wondered why postcss(minimize) was included in the css-loader. Thank you!

Is development v1.0.0(next branch) usable?

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Jan 5, 2018

Is development v1.0.0(next branch) usable?

Not yet, but soon. Since v1.0.0 of the loader will export ES Modules this requires updates in style-loader && extract-text-webpack-plugin aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PostCSS 6.0
3 participants