Skip to content

Use PostCSS 6.0 #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ai opened this issue May 20, 2017 · 17 comments
Closed

Use PostCSS 6.0 #535

ai opened this issue May 20, 2017 · 17 comments

Comments

@ai
Copy link
Contributor

ai commented May 20, 2017

We released major update for PostCSS. It uses less memory and less dependencies, so it will be good to update dependency here.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented May 22, 2017

Upgraded to PostCSS 6 ?

I do it as soon as possible, the relevant postcss-modules-* got their PostCSS 6 update a few hours ago 😛

@michael-ciniawsky michael-ciniawsky added this to the 0.29.0 milestone May 22, 2017
@michael-ciniawsky michael-ciniawsky self-assigned this May 22, 2017
@ai
Copy link
Contributor Author

ai commented May 22, 2017

Maybe we also need to wait cssnano release

@michael-ciniawsky
Copy link
Member

Yep 😄

@ben-eb
Copy link
Contributor

ben-eb commented Jun 3, 2017

Can you try with v4.0.0-rc.0 and let me know how you get on? Going to allow a short period (2 weeks tops) before actually releasing to see if there's anything critical that needs fixing, but it's pretty much how I'd like it to be. I just need your feedback. 😄

https://github.com/ben-eb/cssnano/releases/tag/v4.0.0-rc.0

@alexander-akait
Copy link
Member

@ben-eb I tried, everything works fine 👍 just wait stable release and update all to postcss v6

@EsrefDurna
Copy link

whats the situation ?

@michael-ciniawsky
Copy link
Member

@EsrefDurna Still waiting for cssnano@latest

@wtgtybhertgeghgtwtg
Copy link
Contributor

This would necessitate bumping the minimum supported node version to >=4.0.0, so the object-assign dependency can be dropped here, too.

@martinkadlec0
Copy link

It seems lots of popular libraries are doing just that lately anyway. Honestly, anyone still using <4 node version probably resigned on updating module dependencies long ago.

@joshwiens
Copy link
Member

@wtgtybhertgeghgtwtg - For reference, the minimum supported NodeJS version is 4.3 which comes from Webpack v2, as v1 is no longer officially supported.

The above is usually done via webpack-defaults but in the case of css-loader, @sokra has re-written it completely as a part of his master plan regarding the stylesheets loader chain.

@JabbyPanda
Copy link

JabbyPanda commented Sep 12, 2017

postcss in 6.0.8 had fixed reinstalled the support for Node.js 4.2.2

postcss/postcss#1052,

while as of today postcss v5 does not work with 4.2.2 Node.js version as of today due to the change in js-base-64 library

dankogai/js-base64#56

@tnsicdr
Copy link

tnsicdr commented Oct 16, 2017

Looks like cssnano's postcss dependency has been updated to 6.0. Is anyone working on this?

@alexander-akait
Copy link
Member

@seitensei wait when https://www.npmjs.com/package/cssnano release 4.0.0 stable version

@sachetsharma1
Copy link

Is there a timeline for this?
we are using [email protected] and [email protected] with webpack. On windows machine we run into the following issue :
Module build failed: ModuleBuildError: Module build failed: TypeError: WeakMap: incorrect
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
at Module.require (module.js:468:17)
at require (internal/module.js:20:19)
at Object. (..\node_modules\postcss-font-family-system-ui\src\index.js:2:11)

@alexander-akait
Copy link
Member

@sachetsharma1 which nodejs version you use?

@sachetsharma1
Copy link

[email protected]
[email protected]

Note: post-css-loader version is 2.0.6. I mentioned the css-loader version in both in above comment.

@michael-ciniawsky
Copy link
Member

#642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.