You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Docs should say that minimize has default value depending on webpack production setting.
If this is a feature request, what is motivation or use case for changing the behavior?
Rationale:
I'm trying to adopt browserslist configuration using shared browserslist config (introduced in v2)
css-loader depends on older version of cssnano, which has browserslist@1 as one of dependencies. I'm aware of why is that (#535 (comment)) and I didn't want to use baked-in cssnano anyway (I deliberately use [email protected] in my project)
It turned out that css-loader does use cssnano (in particular: the postcss-merge-rules, which depends on caniuse-db@1 which, in turn depends on browserslist@1) even though I don't ask it to. Or at least I thought I'm not asking it to. In fact I did by using -p flag when calling webpack.
I spent a fair amount of time figuring that out. I feel like the docs should give better insight into that cssnano transforms are used depending on webpack config.
Please mention other relevant information such as your webpack version, Node.js version and Operating System.
webapck 3.10.0
node 8.9.1
macOS 10.13.2
Do you want to request a feature or report a bug?
Bug (documentation)
What is the current behavior?
In a table there's an entry saying that
minimize
isfalse
by default:css-loader/README.md
Line 102 in d999f4a
If the current behavior is a bug, please provide the steps to reproduce.
The default value depends on production setting of webpack (
this.minimize
is set to true when-p
flag is used):css-loader/lib/loader.js
Line 46 in d999f4a
It can be undone only by passing actual setting in a loader query:
css-loader/lib/processCss.js
Line 148 in d999f4a
What is the expected behavior?
Docs should say that
minimize
has default value depending on webpack production setting.If this is a feature request, what is motivation or use case for changing the behavior?
Rationale:
I'm trying to adopt browserslist configuration using shared browserslist config (introduced in v2)
css-loader depends on older version of cssnano, which has browserslist@1 as one of dependencies. I'm aware of why is that (#535 (comment)) and I didn't want to use baked-in cssnano anyway (I deliberately use [email protected] in my project)
It turned out that css-loader does use cssnano (in particular: the postcss-merge-rules, which depends on caniuse-db@1 which, in turn depends on browserslist@1) even though I don't ask it to. Or at least I thought I'm not asking it to. In fact I did by using
-p
flag when callingwebpack
.I spent a fair amount of time figuring that out. I feel like the docs should give better insight into that cssnano transforms are used depending on webpack config.
Please mention other relevant information such as your webpack version, Node.js version and Operating System.
webapck 3.10.0
node 8.9.1
macOS 10.13.2
Related issues:
#289
The text was updated successfully, but these errors were encountered: