feat(tslint): add support to read extended tslint.json
#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
feature/extend-ts-lint
branch
from
e9f8c98 to
9c55670
Compare
alan-agius4
commented
Mar 31, 2018
| @@ -1,118 +1,97 @@ | |||
| import * as ts from "typescript"; | |||
|
|
|||
| import { IOptions } from "tslint"; | |||
There was a problem hiding this comment.
this is only used for interfaces thus not required as a dependency
|
bump @vvakame |
|
@alan-agius4 sorry for late! |
|
Thanks 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #123
I didn't add any new tests as the current tests already cover this part of logic
Maybe we shall add tslint as a peerdepence?
@vvakame as promised here's the PR :)