extends is ignored in tslint.json

[alan-agius4]

tslint rules config from an external node_modules are not being parsed by typescript-formatter.

Example

{
	"extends": [
		"node_modules/@obg/tools.core/config/tslint.json"
	],
	"rulesDirectory": [
		"@obg/tools.lint-rules",
		"tslint-consistent-codestyle",
		"node_modules/tslint-eslint-rules/dist/rules"
	]
}

This won't work due to https://github.com/vvakame/typescript-formatter/blob/master/lib/provider/tslintjson.ts#L49

Ideally for this you use tslint API to read the configuration or another way is to use another library that is capable of extends the json example https://www.npmjs.com/package/@speedy/json-extends.

I'll happy do a PR with any of them. If you tell me which one you prefer.

[vvakame]

sorry for late response.
I'd like to use tslint API pattern.
I want to avoid adding tslint package to dependencies.
We should use dynamic import and change makeFormatCodeOptions function signature (return types will change ts.FormatCodeSettings to Promise<ts.FormatCodeSettings>)

        const tslint = await import("tslint");
        const config = tslint.Configuration.loadConfigurationFromPath(configFileName!);
        const v = config.rules.get("indent")!;
        // .....

[alan-agius4]

I’ll look at it when I have some time this week or the next. Thanks for the feedback though :)

…

On Tue, 27 Mar 2018 at 10:36, Masahiro Wakame ***@***.***> wrote: sorry for late response. I'd like to use tslint API pattern. I want to avoid adding tslint package to dependencies. We should use dynamic import and change makeFormatCodeOptions function signature (return types will change ts.FormatCodeSettings to Promise<ts.FormatCodeSettings>) const tslint = await import("tslint"); const config = tslint.Configuration.loadConfigurationFromPath(configFileName!); const v = config.rules.get("indent")!; // ..... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-WmuOsN4Ij0w2hrWk_EbDOt5Qeb2nks5tifoMgaJpZM4StTJf> .