Skip to content

Fix Japanese translation #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 30, 2020
Merged

Fix Japanese translation #289

merged 10 commits into from
May 30, 2020

Conversation

RyotaBannai
Copy link
Contributor

RyotaBannai added 10 commits May 30, 2020 16:57
@RyotaBannai
fix: 一般的な慣例を指してのas ではなく、次に例示してるcodeを指してas (seen) なので少し誤訳。
5b2ae54
@RyotaBannai
fix: 直訳するとhydrateがわからないと難解なのと後半が若干誤訳。
2363c6d
@RyotaBannai
fix: タグがclient に対してhydrateしろ、と言っているのであって、documentが学習者に教えているわけじゃないので。
07d42b0
@RyotaBannai
fix: it は'data-server-rendered'を指していて、これが主語です。なので文としては'data-server-re…
001a135 
…ndered'がidやセレクタなどに関して何もしないので自分で追加して、と意味です。
@RyotaBannai
add: 追加翻訳されてない部分を対応
36771ed
@RyotaBannai
fix: 難解な部分なのでわかりやすく的確な内容に修正
d16c78b
@RyotaBannai
fix: 誤訳修正と訳をわかりやすく修正。
85db89d
@RyotaBannai
fix 誤訳修正
317d1d6
@RyotaBannai
fix 誤訳修正
9a20f93
@RyotaBannai
fix 誤訳修正
bd3b87e
kazupon
kazupon approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@kazupon kazupon merged commit 904c517 into vuejs:master May 30, 2020
kazupon pushed a commit that referenced this pull request May 31, 2020
@RyotaBannai
fix: typo on rp #289 (#293)
1f20c14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyotaBannai @kazupon