Skip to content

Update routing.md #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2017
Merged

Update routing.md #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de4780
Update routing.md
njleonzhang Sep 22, 2017
3750080
Update routing.md
njleonzhang Sep 22, 2017
b07c44b
Update routing.md
njleonzhang Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zh/routing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export function createApp () {
router,
render: h => h(App)
})
// 注入 router 到根 Vue 实例
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you remove the comment?

See the en docs:
https://github.com/vuejs/vue-ssr-docs/blame/master/en/routing.md#L44

Copy link
Contributor Author

@njleonzhang njleonzhang Sep 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it is a redundancy, because line 39 is same to line 35. But according to the en version, it should be a translation error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the 2 comments have different meanings imo. The L39 is about inject and L39 is about return. So agree with @kazupon .

return { app, router }
 // 返回 app 和 router
 return { app, router }
}
```

Expand Down