Update routing.md #136
Merged
Update routing.md #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
requested changes
Sep 22, 2017
| @@ -36,7 +36,7 @@ export function createApp () { | |||
| router, | |||
| render: h => h(App) | |||
| }) | |||
| // 注入 router 到根 Vue 实例 | |||
There was a problem hiding this comment.
why do you remove the comment?
See the en docs:
https://github.com/vuejs/vue-ssr-docs/blame/master/en/routing.md#L44
There was a problem hiding this comment.
I thought it is a redundancy, because line 39 is same to line 35. But according to the en version, it should be a translation error.
There was a problem hiding this comment.
Yes, the 2 comments have different meanings imo. The L39 is about inject and L39 is about return. So agree with @kazupon .
Jinjiang
reviewed
Sep 22, 2017
zh/routing.md
Outdated
| @@ -36,8 +36,8 @@ export function createApp () { | |||
| router, | |||
| render: h => h(App) | |||
| }) | |||
| // 注入 router 到根 Vue 实例 | |||
| return { app, router } | |||
| // 返回app和router | |||
There was a problem hiding this comment.
Btw. Please leave spaces between Chinese chars and English letters. (like: // 返回 app 和 router)
kazupon
approved these changes
Sep 22, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.