Skip to content

Improve error msg for non-reactive properties #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Improve error msg for non-reactive properties #6735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46976af
Improve error msg for non-reactive properties
kutyel Oct 3, 2017
4aa5c94
Concat strings
kutyel Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/core/instance/proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ if (process.env.NODE_ENV !== 'production') {

const warnNonPresent = (target, key) => {
warn(
`Property or method "${key}" is not defined on the instance but ` +
`referenced during render. Make sure to declare reactive data ` +
`properties in the data option.`,
`Property or method "${key}" is not defined on the instance but
referenced during render. Make sure that this property is reactive,
either in the data option, or for class-based components, by
initializing the property.
See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.`,
target
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use concatenations for each line to avoid the whitespace between the lines.

)
}
Expand All @@ -29,7 +31,7 @@ if (process.env.NODE_ENV !== 'production') {
if (hasProxy) {
const isBuiltInModifier = makeMap('stop,prevent,self,ctrl,shift,alt,meta')
config.keyCodes = new Proxy(config.keyCodes, {
set (target, key, value) {
set(target, key, value) {
if (isBuiltInModifier(key)) {
warn(`Avoid overwriting built-in modifier in config.keyCodes: .${key}`)
return false
Expand All @@ -42,7 +44,7 @@ if (process.env.NODE_ENV !== 'production') {
}

const hasHandler = {
has (target, key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the code style changes?

has(target, key) {
const has = key in target
const isAllowed = allowedGlobals(key) || key.charAt(0) === '_'
if (!has && !isAllowed) {
Expand All @@ -53,15 +55,15 @@ if (process.env.NODE_ENV !== 'production') {
}

const getHandler = {
get (target, key) {
get(target, key) {
if (typeof key === 'string' && !(key in target)) {
warnNonPresent(target, key)
}
return target[key]
}
}

initProxy = function initProxy (vm) {
initProxy = function initProxy(vm) {
if (hasProxy) {
// determine which proxy handler to use
const options = vm.$options
Expand Down