Improve error msg for non-reactive properties #6735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
approved these changes
Oct 3, 2017
yyx990803
requested changes
Oct 3, 2017
src/core/instance/proxy.js
Outdated
| @@ -42,7 +44,7 @@ if (process.env.NODE_ENV !== 'production') { | |||
| } | |||
|
|
|||
| const hasHandler = { | |||
| has (target, key) { | |||
There was a problem hiding this comment.
Can we remove the code style changes?
yyx990803
requested changes
Oct 3, 2017
src/core/instance/proxy.js
Outdated
| referenced during render. Make sure that this property is reactive, | ||
| either in the data option, or for class-based components, by | ||
| initializing the property. | ||
| See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.`, | ||
| target |
There was a problem hiding this comment.
We need to use concatenations for each line to avoid the whitespace between the lines.
|
Thanks, @yyx990803 should be ok right now 👌 |
|
@kutyel you can run |
yyx990803
approved these changes
Oct 3, 2017
ztlevi
pushed a commit
to ztlevi/vue
that referenced
this pull request
Feb 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Improved error message.
Does this PR introduce a breaking change? (check one)
Other information:
Fixes #6657