Skip to content

docs: video link for common tips #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2018
Merged

docs: video link for common tips #643

merged 2 commits into from
May 24, 2018

Conversation

briwa
Copy link
Contributor

@briwa briwa commented May 23, 2018

I thoroughly enjoyed the deck provided under the Common Tips section on the docs. I thought it might help others if they can see the deck while watching the actual Youtube video of Matt O'Connell himself speaking at VueNYC on the actual deck.

Not sure if I'm doing it right on this one, I'm open for ideas or concerns.

Thanks.

@eddyerburgh
Copy link
Member

Good idea, I really enjoyed the talk too :)

How about we link to the video by default, and include a link to the deck, rather than the other way round.

Also we should make sure the parentheses aren't in the link, otherwise it looks like one long link, rather than two separate links. Something like this:

This topic is discussed with more details in a [great presentation by Matt O'Connell](http://slides.com/mattoconnell/deck#/) ([video](https://www.youtube.com/watch?v=OIpfWTThrK8)).

@briwa
Copy link
Contributor Author

briwa commented May 24, 2018

@eddyerburgh Good idea. I was even thinking to simply replace the deck with the video link, since we might no longer need the deck if we have the video link. What do you think? I can also update the ja and zh section.

@eddyerburgh
Copy link
Member

Ok yes, could you replace the deck link with the video link and update the japanese and Chinese translations too please?

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁

@eddyerburgh eddyerburgh merged commit c0b2101 into vuejs:dev May 24, 2018
@briwa briwa deleted the tips-video branch July 30, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants