Skip to content

Add provide option to mount #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 7, 2017
Merged

Add provide option to mount #3

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72c47ca
Add test for accepting provide as an option to mount
Austio Jun 4, 2017
beefb16
Add provide option to mount.js
Austio Jun 5, 2017
24e842f
Support original beforeCreate functions when providing value
Austio Jun 5, 2017
431cc9f
Move provide work to addProvide function
Austio Jun 5, 2017
de333f0
Add provide function value and test
Austio Jun 6, 2017
caa8868
Fix bug where component was re-using constructed beforeCreate functio…
Austio Jun 6, 2017
9b5e557
Create options.beforeCreate in order to push it in handlers and call …
Austio Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/addProvide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ function addProvide (component, options) {
if (originalBeforeCreate) {
originalBeforeCreate.call(this)
}

component.beforeCreate = originalBeforeCreate
Copy link
Contributor Author

@Austio Austio Jun 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so....that was pretty hard to isolate as being the issue. My addProvide was mutating the beforeCreate in between tests. '

This is passing in chrome but not jsdom, will be able to check this out tomorrow :)

Brings me to a thought, when we mount things does it make sense to clone them or give the option for them to be cloned?

}
}

Expand Down