-
Notifications
You must be signed in to change notification settings - Fork 668
Add provide option to mount #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72c47ca
Add test for accepting provide as an option to mount
Austio beefb16
Add provide option to mount.js
Austio 24e842f
Support original beforeCreate functions when providing value
Austio 431cc9f
Move provide work to addProvide function
Austio de333f0
Add provide function value and test
Austio caa8868
Fix bug where component was re-using constructed beforeCreate functio…
Austio 9b5e557
Create options.beforeCreate in order to push it in handlers and call …
Austio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
function addProvide (component, options) { | ||
const provide = typeof options.provide === 'function' | ||
? options.provide | ||
: Object.assign({}, options.provide) | ||
|
||
delete options.provide | ||
|
||
options.beforeCreate = function vueTestUtilBeforeCreate () { | ||
this._provided = typeof provide === 'function' | ||
? provide.call(this) | ||
: provide | ||
} | ||
} | ||
|
||
export default addProvide |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<template> | ||
<div> | ||
{{ fromMount }} | ||
</div> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'component-with-inject', | ||
inject: ['fromMount'], | ||
beforeCreate() { | ||
this.setInBeforeCreate = 'created' | ||
} | ||
}; | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import mount from '../../../../../src/mount' | ||
import ComponentWithInject from '../../../../resources/components/component-with-inject.vue' | ||
|
||
describe('provide option in mount', () => { | ||
it('provides objects which is injected by mounted component', () => { | ||
const wrapper = mount(ComponentWithInject, { | ||
provide: { fromMount: 'objectValue' } | ||
}) | ||
|
||
expect(wrapper.text()).to.contain('objectValue') | ||
}) | ||
|
||
it('provides function which is injected by mounted component', () => { | ||
const wrapper = mount(ComponentWithInject, { | ||
provide () { | ||
return { | ||
fromMount: 'functionValue' | ||
} | ||
} | ||
}) | ||
|
||
expect(wrapper.text()).to.contain('functionValue') | ||
}) | ||
|
||
it('supports beforeCreate in component', () => { | ||
const wrapper = mount(ComponentWithInject, { | ||
provide: { fromMount: '_' } | ||
}) | ||
|
||
expect(wrapper.vm.setInBeforeCreate).to.equal('created') | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to test here for if the provide is a function, otherwise the provide was turning into what appears to be an assertion.