Skip to content

fix(test-utils/wrapper): clarify deprecation note for wrong "get" usage #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(test-utils/wrapper): clarify deprecation note for wrong "get" usage #1688

merged 1 commit into from
Sep 21, 2020

Conversation

valentinpalkovic
Copy link
Contributor

If wrapper.get was called with a vue component instance, a misleading deprecation note was shown
to the user. This fix includes the get method into the deprecation message

fix #1687

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

If `wrapper.get` was called with a vue component instance, a misleading deprecation note was shown
to the user. This fix includes the `get` method into the deprecation message

fix #1687
@lmiller1990
Copy link
Member

thanks!

@lmiller1990 lmiller1990 merged commit a696325 into vuejs:dev Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document deprecation note for wrapper.get
2 participants