Skip to content

Document deprecation note for wrapper.get #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
valentinpalkovic opened this issue Sep 16, 2020 · 0 comments · Fixed by #1688
Closed

Document deprecation note for wrapper.get #1687

valentinpalkovic opened this issue Sep 16, 2020 · 0 comments · Fixed by #1688

Comments

@valentinpalkovic
Copy link
Contributor

Documentation Feedback

You have added a deprecation note about wrapper.find to not use it anymore for vue component search. This is true for wrapper.get as well, because it internally also uses .find(...).

Affected documentation page: Insert a link to the affected page
https://github.com/vuejs/vue-test-utils/blob/99948f58a2f1ef1362fe9e4bf5aca266541a0d35/docs/api/wrapper/get.md
@valentinpalkovic valentinpalkovic mentioned this issue Sep 19, 2020
Merged
13 tasks
lmiller1990 pushed a commit that referenced this issue Sep 21, 2020
@valentinpalkovic
fix(test-utils/wrapper): clarify deprecation note for wrong "get" usa…
a696325 
…ge (#1688)

If `wrapper.get` was called with a vue component instance, a misleading deprecation note was shown
to the user. This fix includes the `get` method into the deprecation message

fix #1687

Co-authored-by: Valentin Palkovič <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test-utils/wrapper): clarify deprecation note for wrong "get" usage
1 participant
@valentinpalkovic