Skip to content

docs(ja): update docs #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 9, 2018
Merged

docs(ja): update docs #2376

merged 9 commits into from
Sep 9, 2018

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Sep 4, 2018

/ping @ktsn @potato4d
🙏

ktsn
ktsn reviewed Sep 4, 2018
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

docs/ja/api/README.md Outdated

ブラウザが `history.pushState` をサポートしないとき、 ルーターが `hash` モードにフォールバックかどうか制御します。デフォルトは `true`
Controls whether the router should fallback to `hash` mode when the browser does not support `history.pushState` but mode is set to `history`.
ブラウザが `history.pushState` をサポートしないとき、 ルーターが `hash` モードにフォールバックかどうか制御しますが、モードは `history` に設定されます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは、when 節は but 以降の文も含んでいると思います。history.pushState がサポートされていないブラウザであるが、モードが history に設定されているときという意味ではないかと。

potato4d
potato4d approved these changes Sep 5, 2018
View reviewed changes
Copy link

@potato4d potato4d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktsnさんのコメント部分の対応が完了すると、あとは良さそうです！

ktsn
ktsn reviewed Sep 7, 2018
View reviewed changes
docs/ja/api/README.md Outdated

ブラウザが `history.pushState` をサポートしないとき、 ルーターが `hash` モードにフォールバックかどうか制御します。デフォルトは `true`
`history.pushState` がサポートされていないブラウザでありますが、モードが `history` に設定されているとき、ルーターは `hash` モードにフォールバックかどうか制御します。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うーん、意味は通じるとは思うのですが若干不自然な感じがしますね……。

history.pushState がサポートされていないブラウザにおいて、モードが history に設定されているとき、ルーターを hash モードにフォールバックするかどうか制御します。

はどうでしょうか？

ktsn
ktsn approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kazupon
Copy link
Member Author

kazupon commented Sep 9, 2018

レビューありがとうございました！

@kazupon kazupon merged commit 99c4436 into vuejs:dev Sep 9, 2018
@kazupon kazupon deleted the docs/ja branch September 9, 2018 16:51
topstack1226 pushed a commit to topstack1226/hospital-frontend that referenced this pull request Jan 3, 2023
docs(ja): update docs (#2376)
7a5ff37 
* chore(ja): pick up

ref: vuejs/vue-router@485d57f

* docs(ja): translate previous commit

	modified:   docs-gitbook/ja/essentials/history-mode.md

* docs(ja): translate advanced/transitions

* docs(ja): pick up

* docs(ja): translate previous commet

ref: vuejs/vue-router@979d8ca

* docs(ja): update essentials/dynamic-matching

ref: vuejs/vue-router@6b2a384

* docs(ja): レビューコメントを反映

ref: vuejs/vue-router#2376 (comment)

* docs(ja): fix typo

* docs(ja): tweak translation
sphinxDevVic added a commit to sphinxDevVic/vue-router that referenced this pull request Feb 11, 2024
@sphinxDevVic
docs(ja): update docs (#2376)
7b7979d 
* chore(ja): pick up

ref: vuejs/vue-router@485d57f

* docs(ja): translate previous commit

	modified:   docs-gitbook/ja/essentials/history-mode.md

* docs(ja): translate advanced/transitions

* docs(ja): pick up

* docs(ja): translate previous commet

ref: vuejs/vue-router@979d8ca

* docs(ja): update essentials/dynamic-matching

ref: vuejs/vue-router@6b2a384

* docs(ja): レビューコメントを反映

ref: vuejs/vue-router#2376 (comment)

* docs(ja): fix typo

* docs(ja): tweak translation
Luisa-m17 added a commit to Luisa-m17/VueRouter that referenced this pull request Feb 20, 2024
@Luisa-m17
docs(ja): update docs (#2376)
a945635 
* chore(ja): pick up

ref: vuejs/vue-router@485d57f

* docs(ja): translate previous commit

	modified:   docs-gitbook/ja/essentials/history-mode.md

* docs(ja): translate advanced/transitions

* docs(ja): pick up

* docs(ja): translate previous commet

ref: vuejs/vue-router@979d8ca

* docs(ja): update essentials/dynamic-matching

ref: vuejs/vue-router@6b2a384

* docs(ja): レビューコメントを反映

ref: vuejs/vue-router#2376 (comment)

* docs(ja): fix typo

* docs(ja): tweak translation
UltraDEV007 added a commit to UltraDEV007/vue-router that referenced this pull request Apr 26, 2024
@UltraDEV007
docs(ja): update docs (#2376)
c446710 
* chore(ja): pick up

ref: vuejs/vue-router@485d57f

* docs(ja): translate previous commit

	modified:   docs-gitbook/ja/essentials/history-mode.md

* docs(ja): translate advanced/transitions

* docs(ja): pick up

* docs(ja): translate previous commet

ref: vuejs/vue-router@979d8ca

* docs(ja): update essentials/dynamic-matching

ref: vuejs/vue-router@6b2a384

* docs(ja): レビューコメントを反映

ref: vuejs/vue-router#2376 (comment)

* docs(ja): fix typo

* docs(ja): tweak translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazupon @ktsn @potato4d