Skip to content

Update navigation.md #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Update navigation.md #1252

merged 1 commit into from
Mar 15, 2017

Conversation

christianmalek
Copy link
Contributor

@christianmalek christianmalek commented Mar 15, 2017

The sentence above the changed text mentions that the string represents the path. But I think literal string path will be much clearer because not everyone wants to read the text. So it's instantly recognizeable that if you just pass a simple string it's a path and not the route name.

The sentence above mentions that the string represents the path. But I think this will be much clearer because not everyone wants to read the text. So it's instantly recognizeable that if you just pass a simple string it's a path and not the route name.
@posva
Copy link
Member

posva commented Mar 15, 2017

Thanks!

@posva posva merged commit 955e5c4 into vuejs:dev Mar 15, 2017
@christianmalek christianmalek deleted the patch-1 branch March 18, 2017 15:55
kazupon added a commit to kazupon/vue-router that referenced this pull request Apr 8, 2017
kazupon added a commit that referenced this pull request Apr 10, 2017
* pick up translation from #1252

* pick up translation from #1307

* translation

* pick up from #1304

* translate previous commit

* pick up from 9b7f766

* translate previous commit

* fix translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants