Fixes styles when combining modules and SCSS #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @danielbastos11 @btoo |
jeremyzahner
changed the title
|
@eddyerburgh It should be fixed now. |
|
@eddyerburgh Found some more bugs. Fixed them and added new tests. New PR incoming. (Just to let you know so you don't release something thats not quite working.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had the problem (#63) that either modules or SCSS would work. They don't seem to do some when combined.
I tried to figure out what the problem is. So far, i've found an issue in the SCSS compiler which i believe i fixed. Still, the classes seem not to end up on the $style of the final VM.
Important: This is WIP and not ready to be merged. I guess it can be if the test suite runs through.
Edit: Fixed now as far as tests are concerned.