Skip to content

Having both css modules and scss in a SFC don't work #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Feb 27, 2018 · 2 comments
Closed

Having both css modules and scss in a SFC don't work #63

ghost opened this issue Feb 27, 2018 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 27, 2018

I've isolated an edge case when using css modules and scss generate a Comment where a HTMLDivElement is expected.

spec.js

const Constructor = Vue.extend(myComponent); const vm = new Constructor().$mount();

myComponent

This doesn't work

<template lang="pug">
  div( :class="$style.box" ) hello
</template>

<style module lang="scss">
.box {
  color: red;
}
</style>

This works

<template lang="pug">
  div( :class="$style.box" ) hello
</template>

<style module>
.box {
  color: red;
}
</style>
@ghost ghost changed the title Having both css modules and scss break test. Having both css modules and scss in a SFC don't work Feb 27, 2018
@eddyerburgh
Copy link
Member

This should be fixed by #73

I've release in 2.2.0. Can you confirm the issue has been fixed?

@jeremyzahner
Copy link
Contributor

@leRenart @eddyerburgh Had the same issue. Found some of the (alleged) problems at least. Also added a unit test that should help fixing this. See #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants