Skip to content

Update incorrect Babel 7 instruction in README.md #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

middric
Copy link
Contributor

@middric middric commented Jan 31, 2020

The readme doc incorrectly states that if you are using versions lower than 24.0.0 of Jest you should use the babel-core@bridge package. This should be versions greater than 24.0.0

I spent a long time banging my head against the wall over this.

The readme doc incorrectly states that if you are using versions lower than 24.0.0 of Jest you should use the babel-core@bridge package. This should be versions _greater_ than 24.0.0

I spent a long time banging my head against the wall over this.
@morficus
Copy link

morficus commented May 1, 2020

man, this really needs to be merged. there goes an hour of my life I shall never get back.

why does this lib still require the use of babel-core@bridge and hasn't transitioned to @babel/core? I see @bable/core as a "peerDependency" so what's up wit that?

@morficus
Copy link

morficus commented May 1, 2020

@escapedcat @eddyerburgh ☝️
(tagging you two since you were involved in updating the docs for Babel 7 compatibility)
any chance we could get this README issue merged to save others from future pain?

@morficus
Copy link

morficus commented May 1, 2020

same comment was left on the original PR as well: #173

@escapedcat
Copy link
Contributor

Sorry for only seeing this now but I can't do anything here :(

@lmiller1990 lmiller1990 merged commit 075b7b1 into vuejs:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants