docs: add info for babel7 peer dep #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldshen
reviewed
Jun 11, 2019
README.md
Outdated
| If you use the latest Version of [jest](https://github.com/facebook/jest) and [babel-jest](https://github.com/facebook/jest/tree/master/packages/babel-jest) make sure to install the needed peer-dependency of `vue-jest` | ||
|
|
||
| ```bash | ||
| npm install --save-dev [email protected] |
There was a problem hiding this comment.
use tag: npm install --save-dev babel-core@bridge
eddyerburgh
reviewed
Sep 8, 2019
eddyerburgh
reviewed
Sep 8, 2019
Co-Authored-By: Edd Yerburgh <[email protected]>
Co-Authored-By: Edd Yerburgh <[email protected]>
|
Sorry, only saw the progress on this now. I added the suggestions. Including a typo ("dteailed") in the commit message. Let me know if I should fix that or if it's ok. |
|
Hey @escapedcat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
| @@ -12,7 +12,7 @@ npm install --save-dev vue-jest | |||
|
|
|||
| ### Usage with Babel 7 | |||
|
|
|||
| If you use the latest Version of [jest](https://github.com/facebook/jest) and [babel-jest](https://github.com/facebook/jest/tree/master/packages/babel-jest) make sure to install the needed peer-dependency of `vue-jest` | |||
| If you use [jest](https://github.com/facebook/jest) < 24.0.0 and [babel-jest](https://github.com/facebook/jest/tree/master/packages/babel-jest) make sure to install babel-core@bridge | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every now and then I check if I still need the babel7 bridge and go through some issues of jest, babel-jest, etc. to figure why I still need it. I ended up here and saw #160.
It seems that a lot of people still being confused about this because a lot of people already moved to Babel v7.
It's fine that vue-jest needs the bridge, but might be easier for others to see immeditately what is needed to make it work. Seems like there's a bigger amount of people who don't look at the peer-deps first. Maybe this helps them.
Let me know if I'm wrong about this please. Thanks.