docs: about the translation of deployment.md in the github pages section #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first time to participate in document translation, and it is not good, please advise, thank you.
jkzing
reviewed
Dec 17, 2018
docs/zh/guide/deployment.md
Outdated
|
|
||
| If you are deploying to `https://<USERNAME>.github.io/<REPO>/`, (i.e. your repository is at `https://github.com/<USERNAME>/<REPO>`), set `baseUrl` to `"/<REPO>/"`. For example, if your repo name is "my-project", your `vue.config.js` should look like this: | ||
| 如果你的部署路径为 `https://<USERNAME>.github.io/<REPO>/`，(即：你的GitHub仓库地址为 `https://github.com/<USERNAME>/<REPO>`)， 此时，你需要将 `baseUrl` 设置为 `"/<REPO>/"`。例如：你的Github仓库名字为"my-project"，那么，你的`vue.config.js`应该为下面所示的代码: |
There was a problem hiding this comment.
有点别扭
"那么，你的 vue.config.js 应该是这样："（or "应该写成这样")
jkzing
reviewed
Dec 17, 2018
docs/zh/guide/deployment.md
Outdated
| @@ -53,7 +53,7 @@ serve -s dist | |||
| } | |||
| ``` | |||
|
|
|||
| 2. Inside your project, create `deploy.sh` with the following content (with highlighted lines uncommented appropriately) and run it to deploy: | |||
| 2. 在你的项目中，新建 `deploy.sh` 并填充下述内容 (突出显示的行未适当注释)，然后运行它来进行部署: | |||
There was a problem hiding this comment.
"突出显示的行未适当注释"，没读懂
"根据情况取消高亮行的注释" 这样？
jkzing
reviewed
Dec 17, 2018
docs/zh/guide/deployment.md
Outdated
| You can also run the above script in your CI setup to enable automatic deployment on each push. | ||
| ::: | ||
|
|
||
| 你还可以选择在你的CI设置中运行上述脚本，便于在每次推送时启用自动部署。 |
There was a problem hiding this comment.
::: tip
:::
This indicates a tip section in vuepress, which should not not be omited.
jkzing
reviewed
Dec 17, 2018
There was a problem hiding this comment.
Nice work!
Remember to keep the paragraph formatting consistence.
FYI chinese-copywriting-guidelines
docs: modify some translations
OweQian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time to participate in document translation, and it is not good, please advise, thank you.