Use keyed loop in guide in line with the style guide #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://vuejs.org/v2/style-guide/#Keyed-v-for-essential the loop should be keyed, I feel this should be reflected in the guide.
|
Good catch, thanks! |
|
Actually this |
|
We should modify the style guide then, because for right now exactly the same example is being used. |
phanan
added a commit
that referenced
this pull request
Sep 16, 2018
* Revert "Add missing patron links (#1771)" This reverts commit 0331976. * Revert "WIP: Re-order Plugins page (#1788)" This reverts commit 3d4bd33. * Revert "fix: removing margins from nested ul/ol, top avoid awkward spacing. (#1761)" This reverts commit 35b875c. * Revert "Use keyed loop (#1767)" This reverts commit e9c3020.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Vue.js style guide the loop should be keyed, I feel this should be reflected in the guide as well.
Please note that I looked at Vue.js for the first time yesterday so I'm completely innocent and green on this one.