Skip to content

fix: removing margins from nested ul/ol, top avoid awkward spacing. #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2018
Merged

fix: removing margins from nested ul/ol, top avoid awkward spacing. #1761

merged 1 commit into from
Sep 16, 2018

Conversation

honzie
Copy link
Contributor

@honzie honzie commented Aug 22, 2018

This is to address the margins in the hacker news example (#1308).

By resetting the margins to 0, this undos the trick that allows for easier text highlighting and anchor positioning.

@phanan phanan merged commit 35b875c into vuejs:master Sep 16, 2018
@phanan
Copy link
Member

phanan commented Sep 16, 2018

Thanks @honzie!

phanan added a commit that referenced this pull request Sep 16, 2018
phanan added a commit that referenced this pull request Sep 16, 2018
* Revert "Add missing patron links (#1771)"

This reverts commit 0331976.

* Revert "WIP: Re-order Plugins page (#1788)"

This reverts commit 3d4bd33.

* Revert "fix: removing margins from nested ul/ol, top avoid awkward spacing. (#1761)"

This reverts commit 35b875c.

* Revert "Use keyed loop (#1767)"

This reverts commit e9c3020.
@honzie honzie deleted the 1308-margin-fix branch January 13, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants