⭐️New: Add vue/no-use-v-if-with-v-for rule
#406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Update] Make `vue/max-attributes-per-line` fixable * [fix] bug and style * [fix] Switch indent calculation method with node and attribute * [fix] don't handle indentation * [add] autofix test max-attributes-per-line.js
* [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix"
michalsnik
suggested changes
Mar 21, 2018
| }] | ||
| ``` | ||
|
|
||
| :+1: Examples of additional **correct** code for this rule with sample `"allowUsingIterationVar": true` options: |
There was a problem hiding this comment.
I guess this is supposed to be incorrect right?
| /> | ||
| ``` | ||
|
|
||
| :-1: Examples of additional **incorrect** code for this rule with sample `"allowUsingIterationVar": true` options: |
lib/rules/no-use-v-if-with-v-for.js
Outdated
| context.report({ | ||
| node, | ||
| loc: node.loc, | ||
| message: "The 'v-for' list variable should be replace with a new computed property that returns your filtered list by this 'v-if' condition." |
There was a problem hiding this comment.
Can we make list to be dynamic value in this message? Also what do you think about this kind of message?
The 'someArray' variable inside 'v-for' directive should be replaced with a computed property that returns filtered array instead. You should not mix 'v-for' with 'v-if'.
|
@michalsnik Thank you for review! |
michalsnik
changed the title
vue/no-use-v-if-with-v-for rulevue/no-use-v-if-with-v-for rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
vue/no-use-v-if-with-v-forrule.This implements rule proposed in #403