Skip to content

valid-v-on: add more modifiers #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
usernamehw opened this issue Jan 19, 2018 · 1 comment
Closed

valid-v-on: add more modifiers #351

usernamehw opened this issue Jan 19, 2018 · 1 comment

Comments

@usernamehw
Copy link

usernamehw commented Jan 19, 2018

  • ESLint Version: 4.15.0
  • eslint-plugin-vue Version: 4.2.0
  • Node Version: 8.9.3
"vue/valid-v-on": 1,
<template>
  <input @keyup.arrow-down="foo">
<!--        ^^^ [eslint-plugin-vue]
                [vue/valid-v-on]
                'v-on' directives don't support the modifier 'arrow-down'. 
-->
</template>

Since vue ^2.5.0 it's possible to use valid modifiers from KeyboardEvent.key.
It would be nice to expand the list of them at least for the most used ones.

@mysticatea
Copy link
Member

Thank you for the report.

I confirmed it on online demo

michalsnik pushed a commit that referenced this issue Apr 1, 2018
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at [email protected]

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test [email protected]

* [fix] I used `output: null` to specify "not fix"

* Fix: no-async-in-computed-properties crash (fixes #390)

* Fix: valid-v-on false positive (fixes #351)

* Fix: indent rules false positive (fixes #375)

* [New] Add `prop-name-casing`

* fix message and category

* fix category

* fix test message

* Set category to undefined

* Add more tests and fix edge case scenario

* attribute order linting

* updating docs, tests and category

* [Update] Make `vue/attributes-order` fixable

* [fix] That `vue/attributes-order` got duplicated when merging README

* [add] messed order properties test case

* [fix] unify input on test case
michalsnik pushed a commit that referenced this issue Jul 11, 2018
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at [email protected]

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test [email protected]

* [fix] I used `output: null` to specify "not fix"

* Fix: no-async-in-computed-properties crash (fixes #390)

* Fix: valid-v-on false positive (fixes #351)

* Fix: indent rules false positive (fixes #375)

* [New] Add `prop-name-casing`

* fix message and category

* fix category

* fix test message

* Set category to undefined

* Add more tests and fix edge case scenario

* attribute order linting

* updating docs, tests and category

*  [New] Add rule `vue/no-use-v-if-with-v-for` (#2)

* [fix] `meta.docs.description` should not end with `.`  consistent-docs-description

* [fix] lint error caused by merging the master for conflict resolution

* [fix] That `vue/attributes-order` got duplicated when merging README

* [fixed] document `correct` and `incorrect` the contrary stated

* [fixed] error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants