Skip to content

[New] Add prop-name-casing #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 21, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions docs/rules/prop-name-casing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# enforce specific casing for the Prop name in Vue components(prop-name-casing)

This rule would enforce proper casing of props in vue components(camelCase).

## :book: Rule Details

(https://vuejs.org/v2/style-guide/#Prop-name-casing-strongly-recommended).

:+1: Examples of **correct** code for `camelCase`:

```js
export default {
props: {
greetingText: String
}
}
```

:-1: Examples of **incorrect** code for `camelCase`:

```js
export default {
props: {
'greeting-text': String
}
}
```

## :wrench: Options

Default casing is set to `camelCase`.

```
"vue/prop-name-casing": ["error", "camelCase|snake_case"]
```
73 changes: 73 additions & 0 deletions lib/rules/prop-name-casing.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/**
* @fileoverview Requires specific casing for the Prop name in Vue components
* @author Yu Kimura
*/
'use strict'

const utils = require('../utils')
const casing = require('../utils/casing')
const allowedCaseOptions = ['camelCase', 'snake_case']

// ------------------------------------------------------------------------------
// Rule Definition
// ------------------------------------------------------------------------------

function create (context) {
const options = context.options[0]
const caseType = allowedCaseOptions.indexOf(options) !== -1 ? options : 'camelCase'
const converter = casing.getConverter(caseType)

// ----------------------------------------------------------------------
// Public
// ----------------------------------------------------------------------

return utils.executeOnVue(context, (obj) => {
const node = obj.properties.find(p =>
p.type === 'Property' &&
p.key.type === 'Identifier' &&
p.key.name === 'props'
)
if (!node) return

const items = node.value.type === 'ObjectExpression' ? node.value.properties : node.value.elements
for (const item of items) {
if (item.type !== 'Property') {
return
}

const propName = item.key.type === 'Literal' ? item.key.value : item.key.name
const convertedName = converter(propName)
if (convertedName !== propName) {
context.report({
node: item,
message: 'Prop "{{name}}" is not {{caseType}}.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be: is not in

data: {
name: propName,
caseType: caseType
}
})
}
}
})
}

// ------------------------------------------------------------------------------
// Rule Definition
// ------------------------------------------------------------------------------

module.exports = {
meta: {
docs: {
description: 'enforce specific casing for the Prop name in Vue components',
category: 'strongly-recommended'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the category to be upcoming?

category: 'upcoming' // 'strongly-recommended'

We're not going to enable this rule by default until the next major release, so we'll stash them in special category for everyone to see what's going to be enabled in next version :)

},
fixable: null, // or "code" or "whitespace"
schema: [
{
enum: allowedCaseOptions
}
]
},

create
}
13 changes: 13 additions & 0 deletions lib/utils/casing.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ function kebabCase (str) {
.toLowerCase()
}

/**
* Convert text to snake_case
* @param {string} str Text to be converted
* @return {string}
*/
function snakeCase (str) {
return str
.replace(/([a-z])([A-Z])/g, match => match[0] + '_' + match[1])
.replace(invalidChars, '_')
.toLowerCase()
}

/**
* Convert text to camelCase
* @param {string} str Text to be converted
Expand Down Expand Up @@ -42,6 +54,7 @@ function pascalCase (str) {

const convertersMap = {
'kebab-case': kebabCase,
'snake_case': snakeCase,
'camelCase': camelCase,
'PascalCase': pascalCase
}
Expand Down
180 changes: 180 additions & 0 deletions tests/lib/rules/prop-name-casing.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,180 @@
/**
* @fileoverview Define a style for the name property casing for consistency purposes
* @author Yu Kimura
*/
'use strict'

// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prop-name-casing')
const RuleTester = require('eslint').RuleTester

// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------

const parserOptions = {
ecmaVersion: 6,
sourceType: 'module',
ecmaFeatures: { experimentalObjectRestSpread: true }
}

const ruleTester = new RuleTester()
ruleTester.run('prop-name-casing', rule, {

valid: [
{
filename: 'test.vue',
code: `
export default {
props: ['greetingText']
}
`,
parserOptions
},
{
filename: 'test.vue',
code: `
export default {
props: ['greetingText']
}
`,
options: ['camelCase'],
parserOptions
},
{
filename: 'test.vue',
code: `
export default {
props: ['greetingText']
}
`,
options: ['snake_case'],
parserOptions
},
{
filename: 'test.vue',
code: `
export default {
props: {
greetingText: String
}
}
`,
parserOptions
},
{
filename: 'test.vue',
code: `
export default {
props: {
greetingText: String
}
}
`,
options: ['camelCase'],
parserOptions
},
{
filename: 'test.vue',
code: `
export default {
props: {
greeting_text: String
}
}
`,
options: ['snake_case'],
parserOptions
}
],

invalid: [
{
filename: 'test.vue',
code: `
export default {
props: {
greeting_text: String
}
}
`,
parserOptions,
errors: [{
message: 'Prop "greeting_text" is not camelCase.',
type: 'Property',
line: 4
}]
},
{
filename: 'test.vue',
code: `
export default {
props: {
greeting_text: String
}
}
`,
options: ['camelCase'],
parserOptions,
errors: [{
message: 'Prop "greeting_text" is not camelCase.',
type: 'Property',
line: 4
}]
},
{
filename: 'test.vue',
code: `
export default {
props: {
greetingText: String
}
}
`,
options: ['snake_case'],
parserOptions,
errors: [{
message: 'Prop "greetingText" is not snake_case.',
type: 'Property',
line: 4
}]
},
{
filename: 'test.vue',
code: `
export default {
props: {
'greeting-text': String
}
}
`,
options: ['camelCase'],
parserOptions,
errors: [{
message: 'Prop "greeting-text" is not camelCase.',
type: 'Property',
line: 4
}]
},
{
filename: 'test.vue',
code: `
export default {
props: {
'greeting-text': String
}
}
`,
options: ['snake_case'],
parserOptions,
errors: [{
message: 'Prop "greeting-text" is not snake_case.',
type: 'Property',
line: 4
}]
}
]
})
9 changes: 9 additions & 0 deletions tests/lib/utils/casing.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,13 @@ describe('getConverter()', () => {
assert.ok(converter('FooBar') === 'foo-bar')
assert.ok(converter('Foo1Bar') === 'foo1bar')
})

it('should conver string to snake_case', () => {
const converter = casing.getConverter('snake_case')

assert.ok(converter('fooBar') === 'foo_bar')
assert.ok(converter('foo-bar') === 'foo_bar')
assert.ok(converter('FooBar') === 'foo_bar')
assert.ok(converter('Foo1Bar') === 'foo1bar')
})
})