[New] Add prop-name-casing
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work @bfkbx960 ! We really appreciate it :) We're going to merge new rules once stable v4 is out 🚀 |
michalsnik
suggested changes
Jan 1, 2018
There was a problem hiding this comment.
Good job @bfkbx960 👍 I left two comments though, update PR and we're ready to 🚢 it :)
lib/rules/prop-name-casing.js
Outdated
| if (convertedName !== propName) { | ||
| context.report({ | ||
| node: item, | ||
| message: 'Prop "{{name}}" is not {{caseType}}.', |
There was a problem hiding this comment.
I think it should be: is not in
lib/rules/prop-name-casing.js
Outdated
| meta: { | ||
| docs: { | ||
| description: 'enforce specific casing for the Prop name in Vue components', | ||
| category: 'strongly-recommended' |
There was a problem hiding this comment.
Can you please change the category to be upcoming?
category: 'upcoming' // 'strongly-recommended'
We're not going to enable this rule by default until the next major release, so we'll stash them in special category for everyone to see what's going to be enabled in next version :)
|
@michalsnik suggestions applied, thank you for code review. |
michalsnik
approved these changes
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements rule proposed in #252