Skip to content

Add vue/max-lines-per-block rule #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions docs/rules/max-lines-per-block.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/max-lines-per-block
description: enforce maximum number of lines in Vue SFC blocks
---
# vue/max-lines-per-block

> enforce maximum number of lines in Vue SFC blocks

- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>

## :book: Rule Details

This rule enforces a maximum number of lines per block, in order to aid in maintainability and reduce complexity.

## :wrench: Options

This rule takes an object, where you can specify the maximum number of lines in each type of SFC block and customize the line counting behavior.
The following properties can be specified for the object.

- `script` ... Specify the maximum number of lines in &lt;script&gt; block. Won't enforce limitation if not specified.
- `template` ... Specify the maximum number of lines in &lt;template&gt; block. Won't enforce limitation if not specified.
- `style` ... Specify the maximum number of lines in &lt;style&gt; block. Won't enforce limitation if not specified.
- `skipBlankLines` ... Ignore lines made up purely of whitespaces.

<eslint-code-block :rules="{'vue/max-lines-per-block': ['error', { template: 2 }]}">

```vue
<!-- ✗ BAD -->
<template>
<div>
hi
</div>
</template>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/max-lines-per-block': ['error', { script: 1, skipBlankLines: true }]}">

```vue
<!-- ✓ GOOD -->
<script>

console.log(1)
</script>
```
110 changes: 110 additions & 0 deletions lib/rules/max-lines-per-block.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
/**
* @author lsdsjy
* @fileoverview Rule for checking the maximum number of lines in Vue SFC blocks.
*/
'use strict'

const { SourceCode } = require('eslint')
const utils = require('../utils')

/**
* @param {string} text
*/
function isEmptyLine(text) {
return !text.trim()
}

module.exports = {
meta: {
type: 'problem',
docs: {
description: 'enforce maximum number of lines in Vue SFC blocks',
categories: undefined,
url: 'https://eslint.vuejs.org/rules/max-lines-per-block.html'
},
fixable: null,
schema: [
{
type: 'object',
properties: {
style: {
type: 'integer',
minimum: 1
},
template: {
type: 'integer',
minimum: 1
},
script: {
type: 'integer',
minimum: 1
},
skipBlankLines: {
type: 'boolean',
minimum: 0
}
},
additionalProperties: false
}
],
messages: {
tooManyLines:
'Block has too many lines ({{lineCount}}). Maximum allowed is {{limit}}.'
}
},
/** @param {RuleContext} context */
create(context) {
const option = context.options[0] || {}
/**
* @type {Record<string, number>}
*/
const limits = {
template: option.template,
script: option.script,
style: option.style
}

const code = context.getSourceCode()
const documentFragment =
context.parserServices.getDocumentFragment &&
context.parserServices.getDocumentFragment()

function getTopLevelHTMLElements() {
if (documentFragment) {
return documentFragment.children.filter(utils.isVElement)
}
return []
}

return {
/** @param {Program} node */
Program(node) {
if (utils.hasInvalidEOF(node)) {
return
}
for (const block of getTopLevelHTMLElements()) {
if (limits[block.name]) {
// We suppose the start tag and end tag occupy one single line respectively
let lineCount = block.loc.end.line - block.loc.start.line - 1

if (option.skipBlankLines) {
const lines = SourceCode.splitLines(code.getText(block))
lineCount -= lines.filter(isEmptyLine).length
}

if (lineCount > limits[block.name]) {
context.report({
node: block,
messageId: 'tooManyLines',
data: {
limit: limits[block.name],
lineCount
}
})
}
}
}
}
}
}
}
84 changes: 84 additions & 0 deletions tests/lib/rules/max-lines-per-block.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/**
* @author lsdsjy
*/
'use strict'

const RuleTester = require('eslint').RuleTester
const rule = require('../../../lib/rules/max-lines-per-block')

const tester = new RuleTester({
parser: require.resolve('vue-eslint-parser'),
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module'
}
})

tester.run('max-lines-per-block', rule, {
valid: [
{
code: `
<script>
console.log(1)
</script>
<template>
<div></div>
</template>
`,
options: [{ template: 1 }]
},
{
code: `
<template>

<div></div>
</template>
`,
options: [{ template: 1, skipBlankLines: true }]
},
{
code: `
<template>
<div>
</div>
</template>
`,
options: [{ script: 1, style: 1 }]
}
],
invalid: [
{
code: `
<template>

<div></div>
</template>
`,
options: [{ template: 1 }],
errors: [
{
message: 'Block has too many lines (2). Maximum allowed is 1.',
line: 2,
column: 7
}
]
},
{
code: `
<script>

const a = 1
console.log(a)
</script>
`,
options: [{ script: 1, skipBlankLines: true }],
errors: [
{
message: 'Block has too many lines (2). Maximum allowed is 1.',
line: 2,
column: 7
}
]
}
]
})