Skip to content

Add vue/max-lines-per-block rule #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 18, 2023
Merged

Add vue/max-lines-per-block rule #2213

merged 6 commits into from
Jun 18, 2023

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Jun 14, 2023

Closes #1443

FloEdelmann
FloEdelmann requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

I have just two small comments.

lsdsjy and others added 2 commits June 14, 2023 19:21
FloEdelmann
FloEdelmann approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi June 14, 2023 11:34
ota-meshi
ota-meshi approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 25a2db5 into vuejs:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

want: vue/max-line rule, limit the number of lines of code per block
3 participants
@lsdsjy @FloEdelmann @ota-meshi