-
-
Notifications
You must be signed in to change notification settings - Fork 681
Auto-fix for vue/component-tags-order #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this!
Looks fine from my side. I have just one minor suggestion.
Wait, there's something I can't determine here. If there is a comment right above the element start tag, should we move the comment too? For example, <style></style>
<!-- this is a comment -->
<script>
</script> Should we move the comment together with the <style></style>
<!-- eslint-disable-next-line vue/multi-word-component-names -->
<script>
export default {
name: 'Comp'
}
</script> @FloEdelmann @ota-meshi Would you have a look at this plz? |
Moving a comment together with the following block would be nice, regardless of whether it is an eslint-disable comment or not. However, I don't think that this would be merge-blocking for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! I have a change request for testcase.
Apply suggestions from code review Co-authored-by: Yosuke Ota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Fixes #1463.
This PR reflects the comments from @ota-meshi in #1512 . It yields a fix for each reported error, so eslint-disable comments work normally. Added a test case for eslint-disable comment.