Skip to content

Feature/1463 #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Feature/1463 #1512

wants to merge 3 commits into from

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jun 10, 2021 •
edited
Loading

resolved #1463

@IWANABETHATGUY
Copy link
Contributor Author

cc @ota-meshi, ready for review

@ota-meshi
Copy link
Member

Thank you for this PR.
Could you change it to auto-fix for each reported element, similar to the order-in-components rule?
Even if there are multiple out-of-order violations, some of them may be suppressed by the eslint-disable comment.

Also, could you add test cases with a comment in before of each element?

IWANABETHATGUY
IWANABETHATGUY commented Jun 10, 2021
View reviewed changes
lib/rules/component-tags-order.js
return code
}
).join('\n')
reportCandidates.forEach((error) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota-meshi, i report each descriptor here, because i want to share the final souceFile, it could improve a little performance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i want to share the final souceFile, it could improve a little performance.

I think it's more important that suppressive comments work than performance. We need to change it to move only the reported element.

@ota-meshi
Copy link
Member

This PR is inactive so I close it.

@ota-meshi ota-meshi closed this Sep 16, 2021
@lsdsjy lsdsjy mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/component-tags-order - Could it be made fixable?
2 participants
@IWANABETHATGUY @ota-meshi