Add "require-default-prop" rule (fixes #122) #135
Conversation
lib/rules/require-default-prop.js
Outdated
| function findPropsWithoutDefaultValue (propsNode) { | ||
| return propsNode.value.properties | ||
| .filter(prop => { | ||
| if (prop.value.type !== 'ObjectExpression') return true |
There was a problem hiding this comment.
In case of spread operator value is going to be undefined:
TypeError: Cannot read property 'type' of undefined
export default {
props: {
a: {
...test
}
}
}| */ | ||
| function propHasDefault (prop) { | ||
| const propDefaultNode = prop.value.properties | ||
| .find(p => p.key.name === 'default') |
There was a problem hiding this comment.
In case of spread operator key is going to be undefined:
TypeError: Cannot read property 'name' of undefined
export default {
props: {
...test
}
}There was a problem hiding this comment.
Ah, I totally forgot about this case.. Thanks for the heads up @armano2 :)
lib/rules/require-default-prop.js
Outdated
| p.key.name === 'props' | ||
| ) | ||
|
|
||
| if (!propsNode || propsNode.value.type !== 'ObjectExpression') return |
There was a problem hiding this comment.
you can move propsNode.value.type !== 'ObjectExpression' into find
|
@michalsnik there is few issues when someone is going to use spread operator in props |
michalsnik
force-pushed
the
add-require-default-prop-rule
branch
from
453490c to
624e8cd
Compare
|
@armano2 thanks for the review! Can you please check once again? Btw. regarding:
I don't check |
This PR implements
require-default-proprule, that was proposed in #122.cc @armano2