Handle spread operator cases

Author: michalsnik

lib/rules/require-default-prop.js

@@ -34,6 +34,7 @@ module.exports = {
     function propIsRequired (prop) {
       const propRequiredNode = prop.value.properties
         .find(p =>
+          p.type === 'Property' &&
           p.key.name === 'required' &&
           p.value.type === 'Literal' &&
           p.value.value === true
@@ -61,8 +62,11 @@ module.exports = {
      */
     function findPropsWithoutDefaultValue (propsNode) {
       return propsNode.value.properties
+        .filter(prop => prop.type === 'Property')
         .filter(prop => {
-          if (prop.value.type !== 'ObjectExpression') return true
+          if (prop.value.type !== 'ObjectExpression') {
+            return true
+          }
 
           return !propIsRequired(prop) && !propHasDefault(prop)
         })
@@ -77,10 +81,11 @@ module.exports = {
         .find(p =>
           p.type === 'Property' &&
           p.key.type === 'Identifier' &&
-          p.key.name === 'props'
+          p.key.name === 'props' &&
+          p.value.type === 'ObjectExpression'
         )
 
-      if (!propsNode || propsNode.value.type !== 'ObjectExpression') return
+      if (!propsNode) return
 
       const propsWithoutDefault = findPropsWithoutDefaultValue(propsNode)
 

tests/lib/rules/require-default-prop.js

@@ -10,7 +10,11 @@
 
 const rule = require('../../../lib/rules/require-default-prop')
 const RuleTester = require('eslint').RuleTester
-const parserOptions = { ecmaVersion: 6, sourceType: 'module' }
+const parserOptions = {
+  ecmaVersion: 6,
+  ecmaFeatures: { experimentalObjectRestSpread: true },
+  sourceType: 'module'
+}
 
 // ------------------------------------------------------------------------------
 // Tests
@@ -44,6 +48,26 @@ ruleTester.run('require-default-prop', rule, {
         }
       `,
       parserOptions
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          props: {
+            ...x,
+            a: {
+              ...y,
+              type: Number,
+              required: true
+            },
+            b: {
+              type: Number,
+              default: 0
+            }
+          }
+        }
+      `,
+      parserOptions
     }
   ],