-
Notifications
You must be signed in to change notification settings - Fork 4.7k
add korean translation site link #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @narusas! Where is the original repo for this?
Update: Disregard. I found it. It looks like it's a personal repo.
Have you been in touch with the Korean translation community from Vue 2?
Hello @bencodezen , I am owner of vuejs-kr org. @narusas moves Vue.js 3 Korean docs into vuejs-kr. Can you set a domain https://v3.ko.vuejs.org/ for https://v3-vuejs-korea.netlify.app/ ? |
Is this the new repo? https://github.com/vuejs-kr/docs-next If so, could someone enable Issues for that repository? |
yes I have enable issues. |
Closes #756. |
Hey @ChangJoo-Park! Thanks for the comment. I'll take a look to get those things moved over. Appreciate it! |
I've added CNAME record for v3.ko.vuejs.org on the DNS. I think you'll need to validate it and provisions TLS cert on netlify for it to work. |
@ChangJoo-Park Can you provide me permissions to the repo for the translation? I need to add it to the Netlify account on our side so we can hook everything up. |
@bencodezen HI, I give you write permission to https://github.com/vuejs-kr/docs-next |
Thanks @narusas! It looks ilke I need also access to the organization vuejs-kr in order to add the site to the Netlify plan. Let me know when that's done! |
@ChangJoo-Park @narusas I'm not sure who can grant the relevant permissions to @bencodezen but we need that sorting before we can put this live. Thanks. |
@bencodezen Please merge this PR :) |
@Skirtle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good now!
Apologies for the complications in getting this approved. There were just a lot of moving parts in this PR and unfortunately permissions were tricky to move around.
Congrats on the v3 translation!
add translation links