Skip to content

add korean translation site link #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

narusas
Copy link
Contributor

@narusas narusas commented Jan 13, 2021

add translation links

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @narusas! Where is the original repo for this?

Update: Disregard. I found it. It looks like it's a personal repo.

Have you been in touch with the Korean translation community from Vue 2?

https://github.com/vuejs-kr/

@bencodezen bencodezen mentioned this pull request Jan 13, 2021
@ChangJoo-Park
Copy link

Hello @bencodezen , I am owner of vuejs-kr org. @narusas moves Vue.js 3 Korean docs into vuejs-kr. Can you set a domain https://v3.ko.vuejs.org/ for https://v3-vuejs-korea.netlify.app/ ?

@skirtles-code
Copy link
Contributor

Is this the new repo?

https://github.com/vuejs-kr/docs-next

If so, could someone enable Issues for that repository?

@narusas
Copy link
Contributor Author

narusas commented Jan 14, 2021

yes I have enable issues.

@skirtles-code
Copy link
Contributor

Closes #756.

@bencodezen
Copy link
Member

Hello @bencodezen , I am owner of vuejs-kr org. @narusas moves Vue.js 3 Korean docs into vuejs-kr. Can you set a domain https://v3.ko.vuejs.org/ for https://v3-vuejs-korea.netlify.app/ ?

Hey @ChangJoo-Park! Thanks for the comment. I'll take a look to get those things moved over. Appreciate it!

@yyx990803
Copy link
Member

yyx990803 commented Feb 9, 2021

I've added CNAME record for v3.ko.vuejs.org on the DNS. I think you'll need to validate it and provisions TLS cert on netlify for it to work.

@bencodezen
Copy link
Member

@ChangJoo-Park Can you provide me permissions to the repo for the translation? I need to add it to the Netlify account on our side so we can hook everything up.

@narusas
Copy link
Contributor Author

narusas commented Feb 22, 2021

@bencodezen HI, I give you write permission to https://github.com/vuejs-kr/docs-next

@bencodezen
Copy link
Member

bencodezen commented Feb 23, 2021

https://github.com/vuejs-kr/docs-next

Thanks @narusas! It looks ilke I need also access to the organization vuejs-kr in order to add the site to the Netlify plan. Let me know when that's done!

@skirtles-code
Copy link
Contributor

@ChangJoo-Park @narusas I'm not sure who can grant the relevant permissions to @bencodezen but we need that sorting before we can put this live. Thanks.

@narusas
Copy link
Contributor Author

narusas commented Mar 3, 2021

@bencodezen
https://v3.ko.vuejs.org is ready.

Please merge this PR :)

@narusas
Copy link
Contributor Author

narusas commented Mar 3, 2021

@Skirtle
What permission is needed on vuejs-kr/docs-next ?

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good now!

Apologies for the complications in getting this approved. There were just a lot of moving parts in this PR and unfortunately permissions were tricky to move around.

Congrats on the v3 translation!

@bencodezen bencodezen merged commit 3281700 into vuejs:master Mar 3, 2021
@ParkDyel ParkDyel deleted the upMaster branch April 18, 2022 03:51
@ParkDyel ParkDyel restored the upMaster branch April 18, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants