Skip to content

Korean Translation #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Korean Translation #802

wants to merge 4 commits into from

Conversation

narusas
Copy link
Contributor

@narusas narusas commented Jan 11, 2021

Description

Korean Translation

Additional Information

Translated: Vuejs Korea Slack (https://vuejs-korea.slack.com) Members

@NataliaTepluhina
Copy link
Member

NataliaTepluhina commented Jan 12, 2021

@narusas thank you so much for the translation work! 🙇🏻 I believe we don't need all the translated changes in diffs, could you please edit the PR to have only a link to the hosted translation website like here? https://github.com/vuejs/docs-next/pull/775/files#diff-9b73f4a12efe0be8829d902ad280c132505c19c2f41c0463375437e5112fab7bR402

If you don't have a hosted translation website and you need it under .vuejs.org please let me know!

@narusas
Copy link
Contributor Author

narusas commented Jan 13, 2021

Hi.
Can I use .vuejs.org ?

@NataliaTepluhina
Copy link
Member

@narusas I think it should be a preferred option. @bencodezen would you mind if I chime you in as you have an access to the domain?

@narusas
Copy link
Contributor Author

narusas commented Jan 13, 2021

Yes. Thank you :)

@bencodezen
Copy link
Member

Hi @narusas! Thanks for the PR. It looks like you're trying to merge into the master branch here, but this repo manages the English translation, so we have to decline this one.

Let's continue our conversation in #805

@bencodezen bencodezen closed this Jan 13, 2021
@narusas narusas deleted the koKR branch January 18, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants