Skip to content

fix generate web-types.json bug #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix generate web-types.json bug #6128

wants to merge 1 commit into from

Conversation

airene
Copy link
Contributor

@airene airene commented Nov 30, 2022

#5674 生成的内容只替换了一个,改成全部替换,上次的修改只修复了一部分
eg. "type": "false | function JOIN slot" => "type": "false | function | slot",才是正确的

This is a ...

  • Bug fix

What's the background?

  1. fix generate web-types.json bug #5674

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

#5674
生成的内容只替换了一个,改成全部替换,上次的修改只修复了一部分
eg. "type": "false | function JOIN slot" => "type": "false | function | slot",才是正确的
@tarasovsn
Copy link
Contributor

Hello, this change is contained in this PR

@airene
Copy link
Contributor Author

airene commented Dec 2, 2022

it fixed by #6095

@airene airene closed this Dec 2, 2022
Copy link

github-actions bot commented Dec 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants