Skip to content

fix(generator-types): Fixed some bugs (web-type.json) #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

tarasovsn
Copy link
Contributor

Hello everyone!

I want to contribute to the development of the project, I hope I'm not the only one who faces syntax highlighting problems when working in IDEA (WebStorm).

This is a ...

  • Bug fix

What's the background?

Not all tags and attributes are highlighted in Intellij IDEA and WebStorm IDEs. Some attributes are incorrectly filled in.

File generation (vetur/attributes.json, vetur/tag.json, vetur/web-type.json) is performed by parsing files /components/*/index.en-US.md

In this regard, there were several parsing errors that I fixed.

  1. Duplication of tags in the web-type.json file, for example, a-anchor, a-card and many others. Different objects have different properties filled in somewhere events, somewhere attributes and somewhere slots.

Снимок экрана 2022-11-12 в 18 29 14

Now they are all combined in a single object.

Снимок экрана 2022-11-12 в 18 31 33

  1. Some tags were incorrectly named, for example.

Снимок экрана 2022-11-12 в 18 32 46

Снимок экрана 2022-11-12 в 18 34 01

Снимок экрана 2022-11-12 в 18 34 16

  1. Some types of attribute values were filled in incorrectly, for example

Снимок экрана 2022-11-12 в 18 36 09

Снимок экрана 2022-11-12 в 18 36 18

Снимок экрана 2022-11-12 в 18 36 28

It was:
Снимок экрана 2022-11-12 в 19 11 31

Become:
Снимок экрана 2022-11-12 в 19 12 59

  1. There are some tags, for example, such as a-table-summary, a-table-summary-row, a-table-summary-cell, which are either difficult to extract from MD files, or are missing there.
    To parse such tags, I took typings/global.d.ts as a basis, unfortunately, so far without filling slots, events and attributes.
    But now the list of tags has become more complete.

Снимок экрана 2022-11-12 в 18 42 47

It was:
Снимок экрана 2022-11-12 в 19 05 12

Become:
Снимок экрана 2022-11-12 в 19 05 59

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@tangjinzhou tangjinzhou requested a review from sendya November 22, 2022 02:16
@tarasovsn tarasovsn mentioned this pull request Dec 2, 2022
5 tasks
@airene
Copy link
Contributor

airene commented Dec 2, 2022

good job 😊

@airene
Copy link
Contributor

airene commented Dec 6, 2022

when can this bugfix merged? 😊

@tarasovsn
Copy link
Contributor Author

Tell me, please, is there anything else I need to do to start workflow further?

@airene
Copy link
Contributor

airene commented Dec 9, 2022

上次是快到3个月了,有提醒自动关闭邮件,然后直接给 tangjinzhou发邮件 才合进去的

@tangjinzhou tangjinzhou merged commit 75c65e0 into vueComponent:main Dec 15, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants