Skip to content

refactor(drawer): use compositionAPI #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2021
Merged

refactor(drawer): use compositionAPI #4708

merged 7 commits into from
Oct 2, 2021

Conversation

ajuner
Copy link
Member

@ajuner ajuner commented Sep 27, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Refactor

API Realization (Optional if not new feature)

同步ant design 4.17

新增

  • autoFocus
  • closeIcon
  • contentWrapperStyle
  • footerStyle
  • forceRender
  • headerStyle
  • push
  • size

变更

  • className(wrapClassName)
  • style(wrapStyle)
  • width(256 -> 378)
  • height(256 -> 378)

插槽

  • extra
  • footer

移除

  • handle

方法

  • afterVisibleChange 用更vue的@afterVisibleChange

What's the effect? (Optional if not new feature)

除了个别API变动基本不影响使用

Changelog description (Optional if not new feature)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

ant design的文档有些API用法也不够完善,感觉后续可以再补点

@ajuner ajuner mentioned this pull request Sep 27, 2021
64 tasks
@ajuner ajuner marked this pull request as draft September 27, 2021 09:36
@ajuner ajuner marked this pull request as ready for review September 27, 2021 09:44
@ajuner
Copy link
Member Author

ajuner commented Sep 28, 2021

有几个点不太确定

  • 删除了让body有overflow的那行代码,有scrollLocker处理 但是不知道有没有其他影响
  • ant-design文档中英文描述不统一
  • scrollLocker的处理方式是否合理

@tangjinzhou tangjinzhou changed the base branch from next to refactor-drawer October 2, 2021 05:06
@tangjinzhou tangjinzhou merged commit 6596bd6 into vueComponent:refactor-drawer Oct 2, 2021
tangjinzhou added a commit that referenced this pull request Oct 2, 2021
tangjinzhou added a commit that referenced this pull request Oct 3, 2021
* refactor(drawer): use compositionAPI

* refactor(drawer): update

* refactor: update

* chore: update

* docs: update

* fix: remove transitionStr

* chore: use useConfigInject

* refactor: drawer #4708

Co-authored-by: ajuner <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants