Skip to content

Body has overflow-x: hidden in destroyed drawer #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Nisgrak opened this issue Sep 27, 2021 · 3 comments
Closed
1 task done

Body has overflow-x: hidden in destroyed drawer #4710

Nisgrak opened this issue Sep 27, 2021 · 3 comments
Assignees
Labels

Comments

@Nisgrak
Copy link

Nisgrak commented Sep 27, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

2.2.8

Environment

Vue 3.2.19

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Ensure that the table of the example have horizontal scroll
  2. Open the drawer
  3. Close the drawer
  4. The table don't have horizontal scroll

What is expected?

The table has horizontal scroll when the drawer with destroy-on-close active is destroyed

What is actually happening?

The body have a overflow-x: hidden that the destroyed drawer didn't remove

@Nisgrak Nisgrak changed the title Overflow hidden in destroyed drawer Body has overflow-x: hidden in destroyed drawer Sep 27, 2021
@ajuner
Copy link
Member

ajuner commented Sep 28, 2021

V3 will fix it, you can pay attention to this #4708

Temporary solution

const afterVisibleChange = (bool: boolean) => {
  if (!bool) {
    document.body.style.removeProperty("overflow");
  }
};

@ajuner ajuner added the waiting 3.0 等待 3.0 label Sep 28, 2021
@ajuner
Copy link
Member

ajuner commented Oct 8, 2021

ref 3.0.0-alpha.1

@ajuner ajuner closed this as completed Oct 8, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants